-
Notifications
You must be signed in to change notification settings - Fork 1.9k
out_kinesis_streams: integrate with shared compression lib #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Basically copied the approach used in out_kinesis_firehose. Signed-off-by: Zoltán Reegn <[email protected]>
1bc52f1 to
2155872
Compare
|
I basically copied what got implemented in out_kinesis_firehose, but I'm sort of a C noob, so I'd appreciate some help in testing (can probably do it myself given enough time but other people are more savvy with this stuff than me). |
|
I want to migrate away from fluentd where this feature was present, and it's a pretty big blocker for me right now. Original PR was #4371 where I'm backporting the compression implementation from. @PettitWesley maybe I can get you to help out, given that you were the original implementor of the out_kinesis_stream feature? |
|
Opened a ticket that covers this issue: #9451 |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Still live. Need feedback from someone competent with the topic. |
|
@cosmo0920 I see you've been involved in a kinesis_output PR, maybe you could have a look? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Although stale, this is still in demand. |
|
It could be useful for reducing bandwidth of requesting to AWS. |
|
Let me quote myself:
|
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Support for gzip compression. Basically copied the approach used in out_kinesis_firehose.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.