Added the ability to specify Fluentd service type #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidDoWant
force-pushed
the
feat/add-fluentd-service-type-field-1
branch
from
0a6c209 to
4cad76e
Compare
Signed-off-by: Fred Heinecke <[email protected]>
solidDoWant
force-pushed
the
feat/add-fluentd-service-type-field-1
branch
from
4cad76e to
f9da5e5
Compare
cw-Guo
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
servicefield for Fluentd services is currently missing the ability to specify the service type to use (clusterip, loadbalancer, etc.). This PR adds it, and defaults to the current hard-coded value (ClusterIP).Which issue(s) this PR fixes:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
N/A