feat: adds toolhead circle style controls #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intial commit Signed-off-by: vajonam <vajonam@github>
Signed-off-by: vajonam <[email protected]>
add step clicks and homing buttons Signed-off-by: vajonam <[email protected]>
add XY homing capability Signed-off-by: vajonam <[email protected]>
added loading and waiting indicators while homing axis. TODO: add spinners as well coming up next while loading. Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
|
I will add the loading indicators features a new PR, that is bit more involved. please review and suggest and code changes, am sure there will be a few. |
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
- when not using XY homing there is room on the center icon, this allows centering of the toolhead in X and Y over the bed. Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
… warning color Signed-off-by: vajonam <[email protected]>
pedrolamas
changed the title
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Signed-off-by: vajonam <[email protected]>
Also removes dead code Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
|
@pedrolamas I don't think I have considered force move, to enable the step buttons. The problem is force move moves the steppers, on a core xy with 3 steppers for z.. the control isn't very useful. so I suspect we leave it as it. |
|
@vajonam you might want to hold off on doing changes for now as I am looking at full theming of this! |
|
Yup am not pushing on this branch, its all yours. |
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
|
Looks good. Haven't found any issues. |
Signed-off-by: Pedro Lamas <[email protected]>
Dark theme
Light theme
|
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
previously approved these changes
Dec 1, 2023
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
approved these changes
Dec 1, 2023
matmen
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Great work, love it!
@pedrolamas Feel free to merge if you're ready
vajonam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the cricle control for the toolhead.
Peek.2023-11-27.09-53.mp4