Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improves status panel layout #1252

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

vajonam
Copy link
Contributor

@vajonam vajonam commented Nov 29, 2023

one possible alternate layout for the status panel.

Before

image

After

image

Fixes #1251
Fixes #1211

Signed-off-by: vajonam [email protected]

@vajonam vajonam force-pushed the fix/status-panel-relayout branch from de59fff to b1a4039 Compare November 29, 2023 15:48
@vajonam vajonam changed the title Fix: status panel relayout fix: status panel relayout Dec 9, 2023
src/components/widgets/status/StatusTab.vue Outdated Show resolved Hide resolved
src/components/widgets/status/StatusTab.vue Outdated Show resolved Hide resolved
@matmen
Copy link
Member

matmen commented Dec 11, 2023

Thanks for your PR, I think the changes look nice. I've left a few comments in my review above

@vajonam
Copy link
Contributor Author

vajonam commented Dec 11, 2023

@matmen that pushes the percentage wrapper, not sure how to address that?

@vajonam
Copy link
Contributor Author

vajonam commented Dec 11, 2023

should be sorted now!

matmen
matmen previously approved these changes Dec 11, 2023
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matmen matmen requested a review from pedrolamas December 11, 2023 19:18
@vajonam
Copy link
Contributor Author

vajonam commented Dec 12, 2023

@matmen can you test this latest commit, because it makes up much less room, I am proposing we used in mdAndUp breakpoints.

@matmen matmen self-requested a review December 12, 2023 07:29
@vajonam vajonam force-pushed the fix/status-panel-relayout branch 2 times, most recently from 7afa396 to a97b836 Compare December 14, 2023 19:38
matmen
matmen previously approved these changes Dec 14, 2023
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Mathis Mensing <[email protected]>
Signed-off-by: vajonam <[email protected]>
@pedrolamas pedrolamas added the UI - QoL Improvements to the UI label Jan 5, 2024
@pedrolamas pedrolamas added this to the 1.27.2 milestone Jan 5, 2024
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Jan 5, 2024
@pedrolamas
Copy link
Member

I've made some tweaks and simplified the styles, will perform some more tests to ensure I haven't broken anything before merging down.

pedrolamas
pedrolamas previously approved these changes Jan 5, 2024
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes and they seem fine on my end, but the positioning of the image isn't quite centered now:

src/components/widgets/status/StatusTab.vue Outdated Show resolved Hide resolved
@pedrolamas pedrolamas changed the title fix: status panel relayout feat: improves status panel layout Jan 8, 2024
@pedrolamas pedrolamas merged commit 9814881 into fluidd-core:develop Jan 8, 2024
5 checks passed
@vajonam vajonam deleted the fix/status-panel-relayout branch January 8, 2024 16:52
@rursache
Copy link

please add a setting for this, i want to use the "old" layout. my thumbnails contain information in each corner which the new layout cuts off

@vajonam
Copy link
Contributor Author

vajonam commented Jan 12, 2024

can you post a screenshot of the old layout with your thumb info? just curious to see.

@rursache
Copy link

rursache commented Jan 12, 2024

@vajonam: can you post a screenshot of the old layout with your thumb info? just curious to see.

here is an example of thumbnail elegoo cura is generating for each sliced model. if you put it inside a circle, you lose all the useful details (filament grams used and cost as the others are in fluidd already).

knight_bust-300x300

how it looks in fluidd now:

Screenshot 2024-01-12 151353

how it looked before:

Screenshot 2024-01-12 151438 aaa

i think its obvious which one was better (at least for me and elegoo users). there is also no saved space so i don't get this change at all

please add a setting toggle for this layout change. thanks!

@vajonam
Copy link
Contributor Author

vajonam commented Jan 12, 2024

I disagree there is no saved space, in the cases where there is longer filename it helps with the layout. However, I understand your issue. click on the thumbnail, will bring up full thumb. I get the issue.

@pedrolamas
Copy link
Member

@rursache I personally wasn't aware of this possibility though I can perfectly see your point.

I've discussed this with @vajonam and we are going to add an option to pick between the "classic" layout (the existing one where progress and thumbnail is separate) and the new "compact" layout (that matches the changes on this PR), that way users can choose which one is better for their purposes.

@rursache
Copy link

@pedrolamas & @vajonam thank you for your effort and consideration!

@rursache
Copy link

rursache commented Feb 5, 2024

@pedrolamas was the option added? where can i find it and switch to the old layout? thanks

@yw4z
Copy link

yw4z commented Feb 7, 2024

296250408-71128d49-9f5d-4302-87c4-8f7d22e1d1dd-2
hi just wanted to share ideas
• moved percentage to title bar
• used progress bar at full length below title bar and this allows to using gcode preview bigger
• added exclude as button. button type is different before

@pedrolamas
Copy link
Member

@pedrolamas was the option added? where can i find it and switch to the old layout? thanks

Just created the PR!

@rursache
Copy link

rursache commented Feb 7, 2024

296250408-71128d49-9f5d-4302-87c4-8f7d22e1d1dd-2 hi just wanted to share ideas • moved percentage to title bar • used progress bar at full length below title bar and this allows to using gcode preview bigger • added exclude as button. button type is different before

looks great!

@pedrolamas was the option added? where can i find it and switch to the old layout? thanks

Just created the PR!

amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - QoL Improvements to the UI
Projects
None yet
5 participants