feat: allow user selection of device camera #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolamas
force-pushed
the
pedrolamas/device-camera-selection
branch
from
2b2c459 to
6663c5c
Compare
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
force-pushed
the
pedrolamas/device-camera-selection
branch
from
6663c5c to
972a98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Device camera is selected in Spoolman, we will now show a small menu where the camera name is to allow the user to change the device camera:
By default, we will select the "environment facing" camera (on the phone/tablet that will be the back camera if available, on a computer it will be whatever camera it can find)
The last camera selected will be stored in the browser local storage so that it gets picked up again next time - without affecting other browsers/devices.
Resolves #1541