fix: Moonraker canbus uuid parameter #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XiaoK <[email protected]>
pedrolamas
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Hi @kluoyun thank you for submitting this PR.
You are absolutely correct on the payload.can_uuids in the mutations file, I completely missed that one!
However, I do not understand the need for the rest of the changes, as far as I can see in the Moonraker documentation, can_uuids is always an array, unless you have actually seen otherwise?
pedrolamas
approved these changes
Dec 12, 2024
pedrolamas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: XiaoK [email protected]