Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spoolman): QR code detection with MJPEG-adaptive camera sources #1579

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

matmen
Copy link
Member

@matmen matmen commented Jan 26, 2025

Fixes a regression introduced by 552a4f6 where MJPEG-adaptive camera sources can't detect QR codes

@matmen matmen added the GH - Bug Something isn't working label Jan 26, 2025
@matmen matmen added this to the 1.31.5 milestone Jan 26, 2025
@matmen matmen requested a review from pedrolamas January 26, 2025 18:43
@pedrolamas
Copy link
Member

I was under the impression this was actually not required anymore, hence why I removed it... is that not the case? 😕

@matmen
Copy link
Member Author

matmen commented Jan 26, 2025

Right now the frame event is only emitted for the first frame, but not subsequent ones. Not sure if other image sources are affected by this too..

@matmen matmen merged commit cf89d32 into fluidd-core:develop Jan 27, 2025
5 checks passed
@matmen matmen deleted the fix/spoolman/mjpeg-adaptive-qr branch January 27, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants