Skip to content

Sync #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 3, 2025
Merged

Sync #2101

merged 25 commits into from
Apr 3, 2025

Conversation

remonh87
Copy link
Member

No description provided.

@remonh87 remonh87 requested a review from jonasbark March 16, 2025 20:27
@jonasbark
Copy link
Member

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

@remonh87
Copy link
Member Author

remonh87 commented Apr 3, 2025

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

@jonasbark yes I see that on Android but not on iOS as there it is still oncardchange:

func onCardChange(_ arguments: Dictionary<AnyHashable, Any>?) {
    channel.invokeMethod("onCardChange", arguments: arguments)
}

so shall we then fix it in Swift in our factory to keep it consistent?

@remonh87
Copy link
Member Author

remonh87 commented Apr 3, 2025

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

fixed

@remonh87 remonh87 merged commit afa3089 into main Apr 3, 2025
7 of 8 checks passed
@jonasbark jonasbark deleted the sync branch May 29, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants