Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null safety #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jibiel
Copy link

@jibiel jibiel commented Jul 10, 2021

9cf4b48 fixes the majority of the analyzer warnings (mostly redundant const declarations).

0889610 migrates the package to null safety.

Notes:

Please consider this PR for release, because the package complicates migration to null safety for the apps that using it.

Fixes #41.
Fixes #45.
Fixes #46.

This was referenced Jul 10, 2021
@nehal076
Copy link

Please merge this PR

@alekoleg
Copy link

Can you take a look guys, @2534290808 , @udiedrichsen @Slackboi please?

@Xezolpl
Copy link

Xezolpl commented Jul 25, 2021

Merge Please 🙏

@pxsanghyo
Copy link

@jibiel Thanks for the PR
I'll override dependency with your PR repo for now.. please don't delete until merged :)

dependency_overrides:
  # Required for null-safety
  # PR: https://github.com/flutter-studio/flutter-icons/pull/47
  flutter_icons:
    git:
      url: git://github.com/jibiel/flutter-icons.git
      ref: master

@mac-spinks
Copy link

When will this be merged in? Waiting for this to migrate my app to null safety

@pelusodan
Copy link

Super looking to get this merged

@mac-spinks
Copy link

Pull request has been here for a month now. When can we expect this to be merged?

@josephcrowell
Copy link

One pull request has been sitting on this repo for almost 2 years...

@fabioselau077
Copy link

github.com/jibiel/flutter-icons.git

flutter pub get
Warning: You are using these overridden dependencies:
! flutter_icons 2.0.0 from git git://github.com/jibiel/flutter-icons.git at 088961
Running "flutter pub get" in app_jason...

@josephcrowell
Copy link

josephcrowell commented Aug 17, 2021

@jibiel would you be willing to take over maintenance on this repo with your fork? Renamed to flutter-vector-icons and added to pub.dev under that name of course.

@jibiel
Copy link
Author

jibiel commented Aug 18, 2021

@josephcrowell

Not sure I'm very motivated and interested to do so.

Since the PR was opened I've switched to a more modular vendor packages — cupertino_icons and ionicons. And I think this may be a more correct approach. Ideally, it should be one set. But often there are some required icons missing, of course.

Don't know how this all will compile in the final build yet, but the package takes 16MB unpacked and knowing that you include dozen of fonts and thousands of icons in the app and using only 1-5% of them is kinda strange.

You are free to use the code from my fork however you see fit, though.

@josephcrowell
Copy link

Cheers

@josephcrowell
Copy link

I pushed out a fork which includes all missing icons including Fontisto fonts and jibiel's fixes for null safety support: https://pub.dev/packages/flutter_font_icons

@gurulnd-git
Copy link

gurulnd-git commented May 20, 2022

I pushed out a fork which includes all missing icons including Fontisto fonts and jibiel's fixes for null safety support: https://pub.dev/packages/flutter_font_icons

Thanks, I thought of doing so. We'll keep using flutter_font_icons and do make someone like me as contributer, so that we can keep that alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null safety support Null safety migration Migrate to sound null safety