Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SALT packages to 3006.9 in provision_salt.sh #4002

Merged

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Nov 1, 2024

@christopherfujino
Copy link
Member Author

@cbracken could you PTAL, bdero is OOO.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

dev/provision_salt.sh Outdated Show resolved Hide resolved
dev/provision_salt.sh Outdated Show resolved Hide resolved
@christopherfujino
Copy link
Member Author

Gonna actually run this on sample devicelab bots to verify before merging.

@christopherfujino
Copy link
Member Author

christopherfujino commented Nov 4, 2024

I am going to run this script on:

To verify that it works.

@christopherfujino
Copy link
Member Author

I am going to run this script on:

To verify that it works.

Running this on ubuntu failed because the *.deb package we download is for package salt-api, but that depends on salt-master, which isn't installed. also, the version of salt-api/salt-master in the ubuntu repos is for version 3006.9, which I don't think we can use.

I got the script to succeed on macOS, but had to make some changes to the script:

  • The curl command needed the -L flag, and in function set_deviceos_grains() I needed to add /usr/local/sbin to the PATH first.

@christopherfujino
Copy link
Member Author

Running sudo salt-call state.apply failed to compile the native C parts of the m2crypto python pip package. I got around this by running sudo /opt/salt/bin/pip install m2crypto ¯_(ツ)_/¯

Copy link
Contributor

auto-submit bot commented Jan 11, 2025

auto label is removed for flutter/cocoon/4002, due to - The status or check suite Linux Cocoon has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Jan 11, 2025
@christopherfujino christopherfujino force-pushed the use-linux-deb-salt-package branch from a65e96e to f8ae23b Compare January 11, 2025 00:15
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App. label Jan 11, 2025
@auto-submit auto-submit bot merged commit 00e0563 into flutter:main Jan 11, 2025
4 checks passed
@christopherfujino christopherfujino deleted the use-linux-deb-salt-package branch January 11, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants