Skip to content

Avoid duplicate work in DartSdkUtil.getSdkVersion #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid duplicate work in DartSdkUtil.getSdkVersion #98

wants to merge 1 commit into from

Conversation

@parlough
Copy link
Member

@parlough parlough commented Nov 22, 2025

  • Inline the readVersionFile static method into getSdkVersion as its used in this singular spot,
    allowing some duplicated logic to be avoided.
  • Replace FileUtil.loadFile with FileUtil.loadFileOrNull which handles the try-catch for us.
  • Avoid unnecessarily recalculating file last modified time.
  • Avoid recreating the same Pair twice.

@parlough parlough marked this pull request as ready for review November 22, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@parlough