-
Notifications
You must be signed in to change notification settings - Fork 336
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
build-mode and pub-get argument to the serve and build CL…
…I tools (#6695)
- Loading branch information
1 parent
3674ca5
commit d13316c
Showing
10 changed files
with
275 additions
and
170 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| // Copyright 2023 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:io'; | ||
|
|
||
| import 'package:args/command_runner.dart'; | ||
| import 'package:devtools_tool/commands/shared.dart'; | ||
| import 'package:devtools_tool/model.dart'; | ||
| import 'package:io/io.dart'; | ||
| import 'package:path/path.dart' as path; | ||
|
|
||
| import '../utils.dart'; | ||
|
|
||
| /// This command builds the DevTools Flutter web app. | ||
| /// | ||
| /// By default, this command builds DevTools in release mode, but this can be | ||
| /// overridden by passing 'debug' or 'profile' as the | ||
| /// [BuildCommandArgs.buildMode] argument. | ||
| /// | ||
| /// If the [BuildCommandArgs.useFlutterFromPath] argument is present, the | ||
| /// Flutter SDK will not be updated to the latest Flutter candidate before | ||
| /// building DevTools. Use this flag to save the cost of updating the Flutter | ||
| /// SDK when you already have the proper SDK checked out. This is helpful when | ||
| /// developing with the DevTools server. | ||
| /// | ||
| /// If the [BuildCommandArgs.updatePerfetto] argument is present, the | ||
| /// precompiled bits for Perfetto will be updated from the | ||
| /// `devtools_tool update-perfetto` command as part of the DevTools build | ||
| /// process. | ||
| /// | ||
| /// If [BuildCommandArgs.pubGet] argument is negated (e.g. --no-pub-get), then | ||
| /// `devtools_tool pub-get --only-main` command will not be run before building | ||
| /// the DevTools web app. Use this flag to save the cost of updating pub | ||
| /// packages if your pub cahce does not need to be updated. This is helpful when | ||
| /// developing with the DevTools server. | ||
| class BuildCommand extends Command { | ||
| BuildCommand() { | ||
| argParser | ||
| ..addUseFlutterFromPathFlag() | ||
| ..addUpdatePerfettoFlag() | ||
| ..addPubGetFlag() | ||
| ..addBulidModeOption(); | ||
| } | ||
|
|
||
| @override | ||
| String get name => 'build'; | ||
|
|
||
| @override | ||
| String get description => 'Prepares a release build of DevTools.'; | ||
|
|
||
| @override | ||
| Future run() async { | ||
| final repo = DevToolsRepo.getInstance(); | ||
| final processManager = ProcessManager(); | ||
|
|
||
| final useLocalFlutter = | ||
| argResults![BuildCommandArgs.useFlutterFromPath.flagName]; | ||
| final updatePerfetto = | ||
| argResults![BuildCommandArgs.updatePerfetto.flagName]; | ||
| final runPubGet = argResults![BuildCommandArgs.pubGet.flagName]; | ||
| final buildMode = argResults![BuildCommandArgs.buildMode.flagName]; | ||
|
|
||
| final webBuildDir = | ||
| Directory(path.join(repo.devtoolsAppDirectoryPath, 'build', 'web')); | ||
|
|
||
| if (!useLocalFlutter) { | ||
| logStatus('updating tool/flutter-sdk to the latest flutter candidate'); | ||
| await processManager.runProcess(CliCommand.tool('update-flutter-sdk')); | ||
| } | ||
|
|
||
| if (updatePerfetto) { | ||
| logStatus('updating the bundled Perfetto assets'); | ||
| await processManager.runProcess(CliCommand.tool('update-perfetto')); | ||
| } | ||
|
|
||
| logStatus('cleaning project'); | ||
| if (webBuildDir.existsSync()) { | ||
| webBuildDir.deleteSync(recursive: true); | ||
| } | ||
| await processManager.runProcess( | ||
| CliCommand.flutter('clean'), | ||
| workingDirectory: repo.devtoolsAppDirectoryPath, | ||
| ); | ||
|
|
||
| logStatus('building DevTools in release mode'); | ||
| await processManager.runAll( | ||
| commands: [ | ||
| if (runPubGet) CliCommand.tool('pub-get --only-main'), | ||
| CliCommand.flutter( | ||
| [ | ||
| 'build', | ||
| 'web', | ||
| '--web-renderer', | ||
| 'canvaskit', | ||
| '--pwa-strategy=offline-first', | ||
| if (buildMode != 'debug') '--$buildMode', | ||
| '--no-tree-shake-icons', | ||
| ].join(' '), | ||
| ), | ||
| ], | ||
| workingDirectory: repo.devtoolsAppDirectoryPath, | ||
| ); | ||
|
|
||
| // TODO(kenz): investigate if we need to perform a windows equivalent of | ||
| // `chmod` or if we even need to perform `chmod` for linux / mac anymore. | ||
| if (!Platform.isWindows) { | ||
| final canvaskitDir = Directory(path.join(webBuildDir.path, 'canvaskit')); | ||
| for (final file in canvaskitDir.listSync()) { | ||
| if (RegExp(r'canvaskit\..*').hasMatch(file.path)) { | ||
| await processManager | ||
| .runProcess(CliCommand('chmod 0755 ${file.path}')); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.