Skip to content

Normalize path before searching for package config#165392

Merged
sigurdm merged 1 commit intoflutter:masterfrom
sigurdm:normalize_dir_for_finding_package_config
Mar 20, 2025
Merged

Normalize path before searching for package config#165392
sigurdm merged 1 commit intoflutter:masterfrom
sigurdm:normalize_dir_for_finding_package_config

Conversation

@sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Mar 18, 2025

If we don't normalize the .absolute.path will look like /child/.
And Directory('/child/.').parent is Directory('/child).

@sigurdm sigurdm requested a review from matanlurey March 18, 2025 12:38
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2025
@sigurdm sigurdm mentioned this pull request Mar 18, 2025
Merged
matanlurey
matanlurey approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sigurdm sigurdm added this pull request to the merge queue Mar 20, 2025
Merged via the queue into flutter:master with commit 95843ca Mar 20, 2025
133 checks passed
@sigurdm sigurdm deleted the normalize_dir_for_finding_package_config branch March 20, 2025 10:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
e1d60f6 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
6e4aa6d 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
52cca6c 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
967bf72 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
279d777 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
e8f7df8 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
2bd7c01 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
ef2ae93 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
5f304aa 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
4f4a780 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
25b1862 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
ca6b292 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
8d9f15b 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
9908937 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
327e467 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
5ea4650 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
930cec5 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
851fef6 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
011f184 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
7cc0848 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
05471db 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
4fcfa96 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
6095257 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
e162041 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
329ec88 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
bb81842 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
6f9addf 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
2227e3b 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
f6cb034 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
fa22808 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
e1487d1 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
7da831d 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
4213a31 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
9a696fc 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
bbbd438 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
12f6bca 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
1fde65e 
…lutter#165392)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
95843ca Normalize path before searching for package config (flutter/f…
53f1f71 
…lutter#165392)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@sigurdm
Normalize path before searching for package config (flutter#165392)
580ba18 
If we don't normalize the `.absolute.path` will look like `/child/.`
And `Directory('/child/.').parent` is `Directory('/child)`.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@sigurdm @romanejaquez
Normalize path before searching for package config (flutter#165392)
f675e34 
If we don't normalize the `.absolute.path` will look like `/child/.`
And `Directory('/child/.').parent` is `Directory('/child)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sigurdm @matanlurey