Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new AI agent skills and updates the README. The new skills provide detailed instructions for an AI, and my review focuses on improving the robustness and correctness of the code examples within these skills. I've suggested changes to make the code safer and more idiomatic, particularly around error handling and event processing. Additionally, I've noted a URL in the README that appears to point to a personal fork instead of the canonical repository.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
|
Looks like there are copyright issues (which are not your fault). I'd try syncing to head and see if they go away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two new AI agent skills for the GenUI package, along with a brief update to the README.md.
Specifically, this adds:
Both of these have been evaluated manually, but I don't yet have a dataset for doing automated evals for them.
Pre-launch Checklist
///).