Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_platform_interface] Add API support query for image streaming #8307

Conversation

liff
Copy link
Contributor

@liff liff commented Dec 16, 2024

Add API support query, supportsImageStreaming for checking if the camera platform supports image streaming.

As requested on this comment: #8234 (comment)

Step 3 from the changing federated plugins guide, split off from #8250 with a new Dart test added.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines for second review

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
@auto-submit auto-submit bot merged commit 34d5039 into flutter:main Jan 7, 2025
77 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 9, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2025
flutter/packages@3fc6b7a...6554751

2025-01-09 [email protected] [webview_flutter_wkwebview] Add a
listener for the canGoBack property change on the iOS platform.
(flutter/packages#8203)
2025-01-09 [email protected] [flutter_svg]
Implement errorBuilder callback (flutter/packages#8364)
2025-01-08 [email protected]
[interactive_media_ads] Adds remaining methods for internal wrapper of
the iOS native `IMAAdDisplayContainer`. (flutter/packages#8153)
2025-01-08 [email protected] [go_router_builder] Add a fallback for
a not null List or Set param (flutter/packages#8349)
2025-01-08 [email protected] Manual roll Flutter (stable)
from 8495dee to 17025dd (2 revisions) (flutter/packages#8396)
2025-01-08 [email protected]
[ci][video_player_android][camera_android_camerax] Manual roll and fix
tests (flutter/packages#8391)
2025-01-07 [email protected] [ci] Run web tests in wasm (unit +
integration). (flutter/packages#8111)
2025-01-07 [email protected] [camera_platform_interface] Add API support query
for image streaming (flutter/packages#8307)
2025-01-07 [email protected]
[camera_android_camerax][video_player_android] Suppresses deprecation of
the `SurfaceProducer.Callback.onSurfaceDestroyed` method
(flutter/packages#8388)
2025-01-07 [email protected] Bump Remaining Plugin Example Apps to
targetSdkVersion >= 34 and compileSdkVersion >= 34
(flutter/packages#8361)
2025-01-07 [email protected] Replace
`onSurfaceCreated` with `onSurfaceAvailable`. (flutter/packages#8384)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants