Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder] Fixes trailing ? by comparing iterables #8521

Merged

Conversation

ValentinVignal
Copy link
Contributor

Fixes flutter/flutter#127373

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from hannah-hyj January 28, 2025 18:12
@hannah-hyj
Copy link
Member

This looks good to me, thank you for the fix!

@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2025
@auto-submit auto-submit bot merged commit dc57079 into flutter:main Jan 29, 2025
77 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router_builder] Route with an empty iterable parameter has an extra ? in its location
2 participants