Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url_launcher_android] Update build.gradle compileSdk version to support version 35 #8525

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TheCodeDaniel
Copy link

The goal of this PR is to upgrade the url_launcher_android compile SDK version.

Issue:
flutter/flutter#162333
The summary of the issue is that an outdated SDK must be dowloaded to compile apps with url_launcher_android.

Pre-launch Checklist

  • [ yes ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [ yes ] I read the [Tree Hygiene] page, which explains my responsibilities.
  • [ yes ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [ yes ] I signed the [CLA].
  • [ yes ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [ yes ] I [linked to at least one issue that this PR fixes] in the description above.
  • [ yes ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • [ yes ] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • [ yes ] I updated/added relevant documentation (doc comments with ///).
  • [ test-exempted ] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [ yes ] All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan
Copy link
Contributor

Please do not indiscriminately mark all the boxes in the checklist without actually doing them; the checklist is there for a reason.

I'm marking the PR as a draft since it's incomplete; please mark it is ready for review once you've done all of the steps.

@stuartmorgan stuartmorgan marked this pull request as draft January 29, 2025 03:30
@stuartmorgan stuartmorgan removed the request for review from gmackall January 29, 2025 03:31
@TheCodeDaniel TheCodeDaniel changed the title Update build.gradle compileSdk version to support version 35 [url_launcher_android] Update build.gradle compileSdk version to support version 35 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants