[video_player_android] Modify to use handlesCropAndRotation to detect the SurfaceTexture Impeller backend
#9107
+98
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
changed the title
handlesCropAndRotation to detect the SurfaceTexture Impeller backendhandlesCropAndRotation to detect the SurfaceTexture Impeller backend
gmackall
approved these changes
May 5, 2025
...android/android/src/main/java/io/flutter/plugins/videoplayer/texture/TextureVideoPlayer.java
Outdated
Show resolved
Hide resolved
| eventListener = new TextureExoPlayerEventListener(mockExoPlayer, mockCallbacks); | ||
| @Test | ||
| @Config(maxSdk = 21) | ||
| public void onPlaybackStateChangedReadySendInitialized_belowAndroid21() { |
There was a problem hiding this comment.
nit: this is actually exactly Android21 right, not below?
There was a problem hiding this comment.
I think this is right because we are testing the sdk <= 21 case, but if I'm missing something, let me know!
13 tasks
…va/io/flutter/plugins/videoplayer/texture/TextureVideoPlayer.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 6, 2025
…n` to detect the `SurfaceTexture` Impeller backend (flutter/packages#9107)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 6, 2025
flutter/packages@e064b04...e800da7 2025-05-06 43054281+camsim99@users.noreply.github.com [video_player_android] Modify to use `handlesCropAndRotation` to detect the `SurfaceTexture` Impeller backend (flutter/packages#9107) 2025-05-06 stuartmorgan@google.com [various] Update READMEs of discontinued packages (flutter/packages#9203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
…r#168392) flutter/packages@e064b04...e800da7 2025-05-06 43054281+camsim99@users.noreply.github.com [video_player_android] Modify to use `handlesCropAndRotation` to detect the `SurfaceTexture` Impeller backend (flutter/packages#9107) 2025-05-06 stuartmorgan@google.com [various] Update READMEs of discontinued packages (flutter/packages#9203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes SDK version check to a call to
SurfaceProducer.handlesCropAndRotationto determine which Impeller backend is used for theTexturebased video player and thus, what rotation correction to apply to correct the rotation of the video.Fixes flutter/flutter#157198.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3