[go_router_builder] Use a mixin instead of an extension #9275
+949
−403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenSorial
force-pushed
the
extension-to-mixin
branch
2 times, most recently
from
d98f78a to
d9971eb
Compare
11 tasks
StevenSorial
force-pushed
the
extension-to-mixin
branch
from
d9971eb to
d9fbbfd
Compare
StevenSorial
force-pushed
the
extension-to-mixin
branch
from
d9fbbfd to
47fa48e
Compare
|
Thanks for the approval. @hannah-hyj @chunhtai is there something left for this to be merged? |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2025
flutter/packages@ecba2db...974f152 2025-06-06 [email protected] [camera_avfoundation] Implementation swift migration - part 4 (flutter/packages#9219) 2025-06-05 [email protected] [go_router_builder] Use a mixin instead of an extension (flutter/packages#9275) 2025-06-05 [email protected] Roll Flutter master to 8b18dde (flutter/packages#9387) 2025-06-05 [email protected] [camera_android_camerax] Fixes premature garbage collection of native objects when app is under memory pressure (flutter/packages#9287) 2025-06-05 [email protected] [google_maps_flutter_platform_interface] Add a new zIndexInt param to marker and deprecate zIndex (flutter/packages#9372) 2025-06-05 [email protected] [camera_android_camerax] Java style improvements (flutter/packages#9234) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step of fixing #106790
This PR changes the generation to use a mixin instead of an extension. The plan is to add the routing methods directly to
GoRouteData. An extension won't be able to override the class implementations, so I changed it to a mixin.I'm not sure about the versioning, so feel free to suggest changes.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3