Skip to content

[ci] Check macOS 15 for Xcode analyzer warnings #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 13, 2025

Xcode 16 is available in CI as of #8968. Check all packages for macOS 15 deprecations.

The last bump #7544

Related flutter/plugins#5778 and flutter/flutter#102835

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@jmagman jmagman self-assigned this Jun 13, 2025
@jmagman jmagman requested a review from vashworth June 18, 2025 21:55
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
Copy link
Contributor

auto-submit bot commented Jun 23, 2025

autosubmit label was removed for flutter/packages/9427, because - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman added autosubmit Merge PR when tree becomes green via auto submit App labels Jun 26, 2025
@auto-submit auto-submit bot merged commit 2e5d6f3 into flutter:main Jun 26, 2025
78 checks passed
@ash2moon ash2moon added the revert Label used to revert changes in a closed and merged pull request. label Jun 27, 2025
auto-submit bot pushed a commit that referenced this pull request Jun 27, 2025
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jun 27, 2025
auto-submit bot added a commit that referenced this pull request Jun 27, 2025
)

Reverts: #9427
Initiated by: ash2moon
Reason for reverting: Looks like this is causing MacOS analyze tasks to fail:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20macos_platform_tests%20stable%20-%20packages/3087/overview
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710976140284515969/+/u/Run_package_tests/xcode_analyze_deprecation/stdout?format=raw
Original PR Author: jmagman

Reviewed By: {vashworth}

This change reverts the following previous change:
Xcode 16 is available in CI as of #8968. Check all packages for macOS 15 deprecations.

The last bump #7544

Related flutter/plugins#5778 and flutter/flutter#102835

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
feduke-nukem pushed a commit to Yobari-Timeliners/golub that referenced this pull request Jun 27, 2025
…509)

Reverts: flutter/packages#9427
Initiated by: ash2moon
Reason for reverting: Looks like this is causing MacOS analyze tasks to fail:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20macos_platform_tests%20stable%20-%20packages/3087/overview
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710976140284515969/+/u/Run_package_tests/xcode_analyze_deprecation/stdout?format=raw
Original PR Author: jmagman

Reviewed By: {vashworth}

This change reverts the following previous change:
Xcode 16 is available in CI as of flutter/packages#8968. Check all packages for macOS 15 deprecations.

The last bump flutter/packages#7544

Related flutter/plugins#5778 and flutter/flutter#102835

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 27, 2025
flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagman jmagman deleted the mac-15-deprecation-check branch June 30, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants