-
-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package_info_plus): support web 0.5.0 #2605
chore(package_info_plus): support web 0.5.0 #2605
Conversation
Thanks for your contribution. This is quite a drastic change and this is also a breaking change. I wouldn't like to do such bump for min Flutter and |
Hi and thank you for the fast reply. There are multiple reasons as to why we want to move to move to web 0.5. |
I wouldn't like to move the min required Flutter and Dart that fast and lose compatibility with lots of projects that still didn't update. I know that bumping versions like that will just not resolve the dependency for such projects, but still, as I said I am against increasing min versions for no reason.
I have already seen it and it doesn't mean anything as Plug Plugins aren't plugins of Google or Dart teams, so their decisions like that are not something that should be followed by everyone without questions.
It all seems clear and logical, but I don't see an answer to my question why extending the range in |
Ok I just checked again and it looks like the flutter bump wouldn't even be needed (no Idea what lead to me beveling this initially). Sorry for the noise :) |
95be792
to
2e6a57e
Compare
Just out of personal interest. I don't feel like you have mentioned why the you (the plus plugin maintainers) consider a major version bump of dependencies to be breaking. |
2e6a57e
to
5b00ba3
Compare
I have already explained to you that the question is in compatibility, not in breaking functionality or semantic versioning. I am not a fan of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is much better. Thanks for updating your PR.
@vbuberen can you provide a rough estimate on when you plan to do the next release? |
Somewhere in March |
@vbuberen can we please 🙏 release this change? It just widen the constraints and would allow to upgrade other packages that requires web 0.5.0. Thanks. |
As seen above we are going with a dependency override for now. So definitely also +1 from us. |
No, unfortunately can't this time. We have a set of other changes that we want to have in the next release as next release is planned to be a breaking change for all plugins anyway. Currently we already have some other PRs merged already like bump min macOS version which we consider as breaking. And there are no plans to do a cherrypick for this single change to do a release for now. Locking this conversation as I have already replied about the timeline. |
Description
Allow the latest 0.5.0 release of the web package.
Other packages like http already require a minimum version of 0.5.0 (changelog)[https://pub.dev/packages/http/changelog#121].
Related Issues
none
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR. (issues are already present on main)Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).