sdexec: fix use after free during teardown #6037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the sdexec module can segfault when a subprocess unit is destroyed as a result of an output channel closing. The channel output callback destroys the channel, then the channel code continues referencing it after the callback. Add a reference count that is held over the callback and the duration of hte function to prevent the segfault. Fixes flux-framework#6036
Problem: there is no test coverage that refcounting protects an sdexec channel from segfaulting if it is destroyed in the output callback. Add a unit test.
|
I also confirmed this addresses the manual reproducer described in the issue. |
|
Thanks! I'll set MWP. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6037 +/- ##
===========================================
+ Coverage 54.42% 83.29% +28.87%
===========================================
Files 471 519 +48
Lines 76273 83686 +7413
===========================================
+ Hits 41515 69710 +28195
+ Misses 34758 13976 -20782
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the sdexec module can segfault when a subprocess unit is destroyed as a result of an output channel closing.
The channel output callback destroys the channel, then the channel code continues referencing it after the callback. Add a reference count that is held over the callback and the duration of the function to prevent the segfault.
Fixes #6036