Skip to content

flux-fsck: support --rootref option #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Jul 8, 2025

Problem: Flux-fsck defaults to fsck-ing the checkpoint stored in the KVS backing store. There is no way to fsck check an alternate
root reference.

Support a new --rootref option where users can specify a specific root reference to begin with.


side notes:

@chu11 chu11 force-pushed the issue6589_fsck_check_inputted_ref branch from bbdd98f to 3e71f0d Compare July 9, 2025 17:54
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (3323cf0) to head (3e71f0d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/cmd/builtin/fsck.c 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6905      +/-   ##
==========================================
- Coverage   83.83%   83.83%   -0.01%     
==========================================
  Files         539      539              
  Lines       90283    90286       +3     
==========================================
- Hits        75693    75692       -1     
- Misses      14590    14594       +4     
Files with missing lines Coverage Δ
src/cmd/builtin/fsck.c 77.94% <87.50%> (+2.94%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chu11 added 5 commits July 18, 2025 10:00
Problem: Some tabbing in t2816-fsck-cmd.t was inconsistent on
use of tabs vs spaces.

Correct the inconsistent tabbing by using tabs everywhere.
Problem: An errant double space was added to a line of code.

Make the double space a single one :-)
Problem: Flux-fsck defaults to fsck-ing the checkpoint stored
in the KVS backing store.  There is no way to fsck check an alternate
root reference.

Support a new --rootref option where users can specify a specific
root reference to begin with.
Problem: The new --rootref option in flux-fsck is not documented.

Add documentation in flux-fsck(1).
Problem: There are no tests for the new flux-fsck --rootref option.

Add tests in t2816-fsck-cmd.t.
@chu11 chu11 force-pushed the issue6589_fsck_check_inputted_ref branch from 3e71f0d to faaec5a Compare July 18, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant