testsuite: add debugging and fix a test failure if verbose set in environment
#6915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A test in t0001-basic.t fails if `verbose` is set in the test environment. This occurs because this variable causes sharness to emit unexpected output: not ok 86 - test_under_flux fails if loaded modules are not unloaded Unset `verbose` in this test so that the environment doesn't affect the outcome.
Problem: t2603-job-shell-initrc.t uses the MULTICORE prereq but doesn't set it, so a test is always skipped. Set the MULTICORE prereq at the top of the test file.
Problem: A few tests are failing as reported in issue flux-framework#6908, but there's no debug information or other output to help diagnose the reason for the failures. Add extra debug to specific failing tests in t2603-job-shell-initrc.t, t2613-job-shell-batch.t, and t3002-pmi.t to assist debug of these failures.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6915 +/- ##
==========================================
+ Coverage 83.89% 83.91% +0.01%
==========================================
Files 540 540
Lines 90610 90610
==========================================
+ Hits 76018 76033 +15
+ Misses 14592 14577 -15 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds set of debugging enhancements for the specific test failures mentioned in #6908.
Additionally, a fix for one test that fails if
verbose=tis set in the environment is included.