broker: convert groups to a module #6959
Conversation
Problem: the groups subsystem uses callbacks to monitor overlay activity, which prevents it from being converted to a built-in broker module. Add an alternative message-based interface for overlay monitoring.
Problem: the broker groups subsystem tracks the broker context, complicating conversion to a built-in broker module. Since groups only needs ctx->h and ctx->rank, update 'struct groups' to track those two items rather than the entire context.
Problem: the state machine calls the groups.get RPC during its own initialization, earlier than necessary and before built-in broker modules are loaded. Call it on entry to QUORUM state to allow the groups subsystem to move to a built-in broker module.
Problem: the broker uses the groups service for quorum management, but groups is a standalone service that doesn't need to be as tightly coupled to the broker as it is. Convert groups to a built-in broker module with autoload=true. The reduced coupling between broker and groups should make both easier to maintain.
Problem: there is no test coverage for the overlay.monitor RPC Add one test.
|
Only somewhat related to this PR, but should builtin modules with |
|
Good question. Maybe we could add an unloadable flag? It is mainly By the way, when I reloaded |
|
Ok, that makes sense. It only came up because modprobe wants a list of all modules, but has to treat |
Problem: the broker uses the groups service for quorum management, but groups is a standalone service that doesn't need to be as tightly coupled to the broker as it is.
Convert groups to a built-in broker module with
autoload=true. The reduced coupling between broker and groups should make both easier to maintain.