Add omitempty to statuses to allow better marshalling#1621
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Mar 25, 2024
Merged
Add omitempty to statuses to allow better marshalling#1621stefanprodan merged 1 commit intofluxcd:mainfrom
stefanprodan merged 1 commit intofluxcd:mainfrom
Conversation
Signed-off-by: Henry Tam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using flagger programmatically, and are marshalling the resource back out for deployment. The lack of omitempty in flagger resources such as the canary is causing issues with our validation through kubeconform, as the null in lastTransitionTime does not conform with date-time.
Cross referencing with other Kubernetes CRDs show most of them allow and omit empty status, so it will be good have something similar here.