-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Patch
instead of Update
for Deployment scaling
#1634
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
- Coverage 34.10% 34.09% -0.01%
==========================================
Files 282 282
Lines 20557 20554 -3
==========================================
- Hits 7011 7008 -3
Misses 12616 12616
Partials 930 930 ☔ View full report in Codecov by Sentry. |
Patch
instead of Update
for Deployment scaling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @relu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if its not too much trouble, could you make the same change for the Daemonset controller?
@aryan9600 I pushed an attempt to solve that for the DS controller, but I'm not convinced it's the right way to go. Since we don't have a |
okay, then lets keep that out of this PR. we can look into it outside of here. |
a39851c
to
7306d56
Compare
Cool. I've removed the commit with the changes to the DS controller and we can revisit it in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This should avoid frequent "Operation cannot be fulfilled" errors from polluting Canary resource events and logs. Signed-off-by: Aurel Canciu <[email protected]>
7306d56
to
553184b
Compare
1 small question here, can we have multiple fields that can be patched with a single command? Like if replicas and labels both need to be patched. |
This should avoid frequent "Operation cannot be fulfilled" errors from polluting Canary resource events and logs.