Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not evaluate incomplete samples from datadog #1763

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

easimon
Copy link
Contributor

@easimon easimon commented Feb 12, 2025

Should fix #1762

@easimon easimon force-pushed the fix/datadog-provider branch 2 times, most recently from 018375f to 7fbcca7 Compare February 12, 2025 17:07
@easimon easimon marked this pull request as draft February 12, 2025 17:07
Signed-off-by: Markus Dobel <markus.dobel@epicompany.eu>
@easimon easimon force-pushed the fix/datadog-provider branch from 7fbcca7 to 2c4b7a6 Compare February 12, 2025 17:12
@easimon easimon marked this pull request as ready for review February 13, 2025 08:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.42%. Comparing base (21acd7e) to head (2c4b7a6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1763   +/-   ##
=======================================
  Coverage   39.42%   39.42%           
=======================================
  Files         284      284           
  Lines       22422    22422           
=======================================
  Hits         8840     8840           
  Misses      12632    12632           
  Partials      950      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanprodan stefanprodan added the area/metrics Metric analysis related issues and PRs label Feb 22, 2025
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @easimon 🏅

@stefanprodan stefanprodan merged commit 8276bfa into fluxcd:main Feb 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Metric analysis related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog metric evaluation seems to look at the wrong sample
3 participants