Skip to content

fix: return accepted values for flags when calling Values.Type() #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: return accepted values for flags when calling Values.Type() #5602

merged 1 commit into from
Oct 28, 2025

Conversation

@jaxels10
Copy link
Contributor

Resolves: #5066 which requested each flags implementation of Values.Type() should return the accepted values.

Feedback welcome.

Notes:

  1. I have not done any changes to flags which only has a single accepted value. This is to not confuse the user. Let me know if I need to change this
  2. I could not find a reference for internal/flags/local_helm_chart_source.go and it seems the supportedHelmChartSourceKinds is never defined in the file

@jaxels10 jaxels10 force-pushed the main branch 4 times, most recently from 9d9e7c7 to c47b009 Compare October 26, 2025 14:16
@jaxels10 jaxels10 mentioned this pull request Oct 26, 2025
Closed
matheuscscp
matheuscscp reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and the fix is working, but there's a few comments we should probably address

@matheuscscp matheuscscp added the backport:release/v2.7.x To be backported to release/v2.7.x label Oct 28, 2025
stefanprodan
stefanprodan approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheuscscp matheuscscp merged commit 31287b9 into fluxcd:main Oct 28, 2025
7 checks passed
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v2.7.x:

@fluxcdbot fluxcdbot mentioned this pull request Oct 28, 2025
Merged
@matheuscscp matheuscscp mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matheuscscp matheuscscp matheuscscp left review comments

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees

No one assigned

Labels

backport:release/v2.7.x To be backported to release/v2.7.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change flags with fixed allowed values to show the actual values

4 participants

@jaxels10 @fluxcdbot @matheuscscp @stefanprodan