Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
luxas committed Aug 13, 2020
1 parent d4b45c7 commit 695828d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ linters:
# - godox don't error although there are TODOs in the code
- funlen
- whitespace
# - wsl allow "non-ideomatic" whitespace formattings for now
# - wsl allow "non-idiomatic" whitespace formattings for now
- goprintffuncname
- gomnd
- goerr113
Expand Down
2 changes: 1 addition & 1 deletion bitbucket/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ limitations under the License.
package bitbucket

import (
// Dummy import until we have the implementation ready.
// TODO: Dummy import until we have the implementation ready.
_ "github.com/ktrysmt/go-bitbucket"
)
2 changes: 1 addition & 1 deletion github/resource_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (r *userRepository) Reconcile(ctx context.Context) (bool, error) {
return true, r.Update(ctx)
}

// Delete deletes the current resource irreversible.
// Delete deletes the current resource irreversibly.
//
// ErrNotFound is returned if the resource doesn't exist anymore.
func (r *userRepository) Delete(ctx context.Context) error {
Expand Down
2 changes: 1 addition & 1 deletion gitlab/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ limitations under the License.
package gitlab

import (
// Dummy import until we have the implementation ready.
// TODO: Dummy import until we have the implementation ready.
_ "github.com/xanzy/go-gitlab"
)
2 changes: 1 addition & 1 deletion gitprovider/gitprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ type Updatable interface {
// Deletable is an interface which all objects that can be deleted
// using the Client implement.
type Deletable interface {
// Delete deletes the current resource irreversible.
// Delete deletes the current resource irreversibly.
//
// ErrNotFound is returned if the resource doesn't exist anymore.
Delete(ctx context.Context) error
Expand Down

0 comments on commit 695828d

Please sign in to comment.