Conversation
Signed-off-by: Soule BA <[email protected]>
|
gitlab tests keep failing. I tried a new version locally without success. @makkes any idea? |
I'll take a look. |
|
I was able to find out that the failures start appearing with github.com/xanzy/go-gitlab v0.106.0 and v0.105.0 still works. Need to dig deeper what changed in 106. |
|
I bisected the upstream codebase and identified the bad commit to be xanzy/go-gitlab@f49ba02. I suppose we're depending on a specific type of error to be returned. |
The upstream gitlab library changed the way it handles 404s returned from the GitLab instance in the way that it now simply returns a sentinel error (see xanzy/go-gitlab@f49ba02#diff-044b5a63fdba539bf87d25040d91912aec34173e76af7b9e0f40d14da57edebeR973-R974) for details. We now need to check for that sentinel error explicitly and return an appropriate gitprovider error type. Signed-off-by: Max Jonas Werner <[email protected]>
|
@souleb I pushed a commit to fix the e2e errors for GitLab. Please see the commit message for an explanation. It's awful. 🤦🏻♂️ They just changed the API surface in a breaking way. |
|
There seems to be one case missing somewhere but I don't have time today to dig into it. |
|
Let's go with go-gitlab v0.105.0 if that's the most recent version that works for us. |
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
|
I fixed the GitLab breaking changes, but now GitHub broke their public API, the fix is here google/go-github#3248 with no release for it. I will try pin go-github to main. |
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
3 participants
Description
Update dependencies, notably
github.com/google/go-github/v64.