-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting time into this 🥝
I have to think for a bit about removing the structures from the spec docs, but do have some comments in the meantime.
9e5a472
to
f4ce615
Compare
29e39a6
to
cf21f30
Compare
- Add note about `dependsOn` and update ordering - Replace references to "operator" with "controller" for consistency - Add values override docs
This documents what is considered a desired state transition, and the resulting upgrade and status condition semantics.
cf21f30
to
763329d
Compare
I discussed this a bit with @stefanprodan, and we both think the in-documentation code blocks should stay. Reason for this is that once we get out of the "rapid development cycle", new proposals should be made against the spec, and this becomes hard without them being available. We are currently working on more governance (including documentation) for the Flux project, and I will make sure this process will be documented somewhere (cc: @scottrigby). I also think this means that the documentation within the spec that is added in this PR should be rewritten to something that describes desired application behaviour, instead of being explanatory to a user. But this can be taken care of as a follow up action, including moving bits and pieces to the I took the liberty to rebase the PR and undo the code removals from the spec so this can be merged in the meantime, as we are trying to make new controller releases today and would like to see this included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GG @seaneagan and @hiddeco
This attempts to work towards the
extend documentation around managing Helm releases
task mentioned in fluxcd/flux2#238:The thought here is to have a leveled documentation, increasing detail in each level, and avoiding too much duplication between levels:
This: