-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: don't install CRDs of disabled subcharts #941
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthijs Brouns <[email protected]>
7a5e1b7
to
342b5e0
Compare
if err := helmchartutil.ProcessDependenciesWithMerge(chrt, vals); err != nil { | ||
return nil, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this actually works, we'll need it on upgrade too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I could probably add it to applyCRDs
instead to cover all the use-cases, but that would mean changing the signature of that function to also include the vals
. Is that better?
This results in |
I can put in some time tomorrow or Thursday I think to write test cases and do it on upgrade as well. Any other concerns that need to be addressed? |
Reading this I hope we are safe:
In any case, if anywhere in that logic a map from the chart is touched, calling the function twice will mess up the whole thing, so we really need a test. |
Possible solution for #938