Migrate secrets handling to pkg/runtime/secrets #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
matheuscscp
approved these changes
Jul 6, 2025
matheuscscp
changed the title
|
Please squash 🙏 |
cappyzawa
force-pushed
the
feat-runtime-secrets-migration-pr1
branch
from
046a0a9 to
4469667
Compare
matheuscscp
reviewed
Jul 6, 2025
Replace custom secret handling with pkg/runtime/secrets package: - Remove entire internal/secret package - Use secrets.TLSConfigFromSecret() for TLS certificates - Use secrets.ProxyURLFromSecret() for proxy configuration - Use secrets.PullSecretsFromServiceAccount() for ServiceAccount handling - Consolidate all pull secrets into single k8schain flow - Update tests to use pkg/runtime/secrets constants Signed-off-by: cappyzawa <[email protected]>
cappyzawa
force-pushed
the
feat-runtime-secrets-migration-pr1
branch
from
4469667 to
9e07a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates TLS certificate and proxy configuration handling to pkg/runtime/secrets v0.63.0 for image-reflector-controller as part of fluxcd/flux2#5433.