Prepend spec.summary to the github status message #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepend Alert: spec.summary to the name of github notification. Signed-off-by: Alex Kashintsev <[email protected]>
|
Feels like dup of #340 |
|
This will break GH status update, the summary can have 1000+ characters. Given this we can't use the summary, we need a different API, see fluxcd/flux2#2639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend Alert: spec.summary to the name of github notification.
I would like to use Flux notification to github which will show the badge on successfull/unsuccessfull reconciliation.
But I would like to modify message and include name of the region which was able to apply changes.
Currently Flux notification controller does not take into account configured summary of the alert.
By default if there is no summary in the metadata it will generate default status message.
if summary is provided Notifications controller will prepend it to the name of status: by doing this multiple regions can report to the same status in Github.