fix: fsNetworkHttpRequestPost now allocates pointer correctly#28
Merged
Gurgel100 merged 3 commits intoflybywiresim:mainfrom Mar 27, 2025
Merged
fix: fsNetworkHttpRequestPost now allocates pointer correctly#28Gurgel100 merged 3 commits intoflybywiresim:mainfrom
Gurgel100 merged 3 commits intoflybywiresim:mainfrom
Conversation
Gurgel100
reviewed
Mar 5, 2025
Contributor
Gurgel100
left a comment
Gurgel100
left a comment
There was a problem hiding this comment.
Thank you for finding this use after free bug.
Gurgel100
approved these changes
Mar 6, 2025
Contributor
Gurgel100
left a comment
Gurgel100
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running into an issue where we were trying to send some post requests to sentry and the pointer would not resolve correctly. This PR fixes the pointer allocation so the post requests will actually contain the data