chore: update rust edition to 2024#30
Open
nakajimayoshi wants to merge 1 commit intoflybywiresim:mainfrom
Open
chore: update rust edition to 2024#30nakajimayoshi wants to merge 1 commit intoflybywiresim:mainfrom
nakajimayoshi wants to merge 1 commit intoflybywiresim:mainfrom
Conversation
Author
|
@Gurgel100 Disable layout tests in BindgenThe MSFS SDK headers use interfaces with virtual methods. You can't really perform meaningful layout tests when you're interacting with these types via opaque pointers instead of passing by value. #![allow(unsafe_op_in_unsafe_fn)]Adding unsafe blocks to the bodies of all the unsafe functions would involve adding more boilerplate to the build.rs file than is needed, for no additional safety benefit. The functions themselves are already marked as unsafe. |
Gurgel100
approved these changes
Jul 19, 2025
Gurgel100
approved these changes
Jul 20, 2025
Gurgel100
reviewed
Jul 23, 2025
Gurgel100
reviewed
Sep 15, 2025
Gurgel100
approved these changes
Feb 1, 2026
Gurgel100
requested changes
Feb 1, 2026
1dcc2db to
670c386
Compare
3da224d to
7955e52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the crate to be compatible with the latest edition of rust (2024 as of creating this). without introducing any breaking API changes.
I have squashed some of the existing compiler errors but the vast majority seem to be stemming from a bindgen rust file that's generated at compile time.
Edit: I managed to get rid of the build errors by updating bindgen to the latest version