Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audience key versions #87

Open
wants to merge 32 commits into
base: biscuit_integration
Choose a base branch
from
Open

Audience key versions #87

wants to merge 32 commits into from

Conversation

daeMOn63
Copy link
Contributor

@daeMOn63 daeMOn63 commented Oct 21, 2020 •
edited
Loading

Add audience key management CLI commands:

  • ListKeyVersions
  • CreateKeyVersion
  • DeleteKeyVersion
  • RestoreKeyVersion

Updated the AudienceKeyNamerFunc to allow an env variable (AUDIENCE_KEYS) to overwrite the audience key version, when set to a json payload like:

{
    "https://audience.url": "new/key/cryptoKeyVersions/2", 
    "https://another.url": "new/key/cryptoKeyVersions/5"
}

daeMOn63
daeMOn63 commented Oct 21, 2020
View reviewed changes
pkg/kmssign/kms.go Outdated Show resolved Hide resolved
daeMOn63
daeMOn63 commented Oct 21, 2020
View reviewed changes
pkg/cli/audiences.go Outdated Show resolved Hide resolved
titanous
titanous approved these changes Nov 9, 2020
View reviewed changes
pkg/kmssign/kms.go Outdated Show resolved Hide resolved
pkg/kmssign/kms.go Outdated Show resolved Hide resolved
@daeMOn63
Copy link
Contributor Author

Waiting on #72 review before merging

daeMOn63 and others added 17 commits December 11, 2020 09:24
@daeMOn63
idp: extract access token generation
a11460e
@daeMOn63
add biscuit wrappers and helpers to generate, sign and verify hubauth…
3b83165 
… biscuits
@daeMOn63
idp/token: split builder in multiple files
0f47b7a
@daeMOn63
add biscuit metadata and expiration date
9bbf14b 
Verifiers must now provide the current time for verifying the biscuit,
and can extract user informations.

User's pubkeys are now provided in http param when exchanging code.
Removed block count from biscuit weakening the signature.
@daeMOn63
update returned token type to depend on configured builder
a571a38
@daeMOn63
add access token builder creation switch from env
9ea5bf3
@daeMOn63
add /public-key HTTP endpoint
70e61c8
@daeMOn63
update biscuit verify audience key type to use *ecdsa.PublicKey inste…
8846d2b 
…ad of *kmssign.Key
@daeMOn63
simplify http public key encoding
6cce9d2
@daeMOn63
add helper to create UserKeyPair from an ecdsa.PrivateKey
5c2751a
@daeMOn63
cleanup
4e32e6a
@daeMOn63
add biscuit setup instructions in readme
23ffbf8
@daeMOn63
renamed signedPbBuilder to bearerBuilder
4ee2432
@daeMOn63
extracted user signature nonce and timestamp
d84af72
@daeMOn63
idp/token: add biscuit tests
31f2745
@daeMOn63
moved biscuit pkg to biscuit-go repo
88c2864
@daeMOn63
go mod tidy
249a3e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanous titanous titanous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daeMOn63 @titanous