fix(timber): reset default context handling in renderComponent function#617
Open
mahmoud-alawad wants to merge 2 commits intoflyntwp:masterfrom
Open
fix(timber): reset default context handling in renderComponent function#617mahmoud-alawad wants to merge 2 commits intoflyntwp:masterfrom
mahmoud-alawad wants to merge 2 commits intoflyntwp:masterfrom
Conversation
Contributor
|
@mahmoud-alawad many thanks for the pr. It contains a TODO comment and also i am unsure about what will be the benefit of the changes? Could you please make a review and also add a description? |
Author
|
@timohubois This PR is related to #579 I've implemented a solution to fix the issue with inheriting data from parent components. ChangesWith this PR, developers now have full control over Twig's include options when rendering components: {{ renderComponent('ComponentName', {data}, {includeContext: false}) }}Available OptionsDevelopers can now pass the following options as the third parameter:
Examples{# Render component without inheriting parent context #}
{{ renderComponent('Card', cardData, {includeContext: false}) }}
{# Render component without inheriting parent context and without passing data #}
{{ renderComponent('Breadcrumbs', {}, {includeContext: false}) }}
{# Render optional component that may not exist #}
{{ renderComponent('OptionalWidget', data, {ignoreMissing: true}) }}
{# Render user-generated component with security restrictions #}
{{ renderComponent('UserTemplate', data, {sandboxed: true}) }}This provides developers with the flexibility to control component rendering behavior based on their specific needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.