Connector Interface & Bigquery Connector#209
Merged
wild-endeavor merged 28 commits intomainfrom Oct 29, 2025
Merged
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
reviewed
Oct 24, 2025
plugins/connectors/src/flyteplugins/connectors/bigquery/connector.py
Outdated
Show resolved
Hide resolved
kumare3
reviewed
Oct 24, 2025
plugins/connectors/src/flyteplugins/connectors/bigquery/task.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
commented
Oct 29, 2025
pyproject.toml
Outdated
|
|
||
| [tool.uv.sources] | ||
| flyteidl2 = { git = "https://github.com/flyteorg/flyte.git", subdirectory = "gen/python", rev = "v2" } | ||
| flyteidl2 = { git = "https://github.com/flyteorg/flyte.git", subdirectory = "gen/python", rev = "16e01e918fe9d4ec73955cbd707435996ddac83f" } |
Member
Author
There was a problem hiding this comment.
Need to merge this first. flyteorg/flyte#6659
plugins/connectors/src/flyteplugins/connectors/bigquery/connector.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
previously approved these changes
Oct 29, 2025
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
previously approved these changes
Oct 29, 2025
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new async connector framework for Flyte, enabling extensible and standardized integration with external systems via connectors. It adds core connector abstractions, a registry for managing connectors, a gRPC-based connector service with metrics, and comprehensive tests for the new service
Connector Framework and Registry
AsyncConnectorbase class,ResourceMeta,Resource, andConnectorRegistryinsrc/flyte/connectors/_connector.py, providing a standardized interface for async connectors and a registry for managing them. Includes serialization/deserialization for resource metadata and support for connector metrics/logs.AsyncConnectorin the public API viasrc/flyte/connectors/__init__.py.Connector Service Implementation
src/flyte/connectors/_server.pyimplementing gRPC services for connector operations (create, get, delete, metrics, logs), integrating Prometheus metrics for observability and robust error handling.Testing and Validation
tests/flyte/connector/test_connector_service.pywith a dummy connector and extensive tests for the connector service, validating all major operations and error handling.