[WIP] Load the task and start the controller in parallel #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add client retrieval from init config in runtime.py - Refactor controller thread startup logic with separate _wait method - Ensure controller is properly initialized before running coroutines 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
changed the title
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
Sep 30, 2025
| bundle = None | ||
| if tgz or pkl: | ||
| bundle = CodeBundle(tgz=tgz, pkl=pkl, destination=dest, computed_version=version) | ||
| init(org=org, project=project, domain=domain, image_builder="remote", **controller_kwargs) |
There was a problem hiding this comment.
We created a gRPC channel twice (init, create_controller). I think we should be able to reuse it in the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1000ms -> 750 ms