Skip to content

Add support cache for dynamic spec #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

re generate protobuf after conflicts resolved

5e8e14d
Select commit
Loading
Failed to load commit list.
Open

Add support cache for dynamic spec #6372

re generate protobuf after conflicts resolved
5e8e14d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2025 in 0s

58.59% (+0.10%) compared to 8f02ac6

View this Pull Request on Codecov

58.59% (+0.10%) compared to 8f02ac6

Details

Codecov Report

Attention: Patch coverage is 69.55530% with 267 lines in your changes missing coverage. Please review.

Project coverage is 58.59%. Comparing base (8f02ac6) to head (5e8e14d).

Files with missing lines Patch % Lines
...atalog/pkg/manager/impl/future_artifact_manager.go 64.55% 75 Missing and 20 partials ⚠️
...ontroller/nodes/catalog/datacatalog/datacatalog.go 73.39% 42 Missing and 16 partials ⚠️
...ytepropeller/pkg/controller/nodes/dynamic/cache.go 72.82% 36 Missing and 14 partials ⚠️
...epropeller/pkg/controller/nodes/dynamic/handler.go 74.07% 21 Missing and 7 partials ⚠️
...atacatalog/pkg/manager/impl/artifact_data_store.go 59.09% 6 Missing and 3 partials ⚠️
datacatalog/pkg/rpc/datacatalogservice/service.go 0.00% 7 Missing ⚠️
...atacatalog/pkg/repositories/transformers/future.go 75.00% 4 Missing and 2 partials ⚠️
...eller/pkg/controller/nodes/catalog/noop_catalog.go 0.00% 6 Missing ⚠️
...ontroller/nodes/catalog/datacatalog/transformer.go 85.00% 2 Missing and 1 partial ⚠️
...peller/pkg/controller/nodes/dynamic/transformer.go 82.35% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6372      +/-   ##
==========================================
+ Coverage   58.48%   58.59%   +0.10%     
==========================================
  Files         940      944       +4     
  Lines       71584    72442     +858     
==========================================
+ Hits        41867    42444     +577     
- Misses      26534    26750     +216     
- Partials     3183     3248      +65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov