Allow configuring deployment annotations in Helm chart #6385
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Code Review Agent Run Status
|
ppeerttu
force-pushed
the
feature/configure-deployment-annotations
branch
from
caf3043 to
9d71fb7
Compare
Code Review Agent Run #3cb024Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6385 +/- ##
=======================================
Coverage 58.49% 58.49%
=======================================
Files 940 940
Lines 71566 71566
=======================================
Hits 41860 41860
Misses 26525 26525
Partials 3181 3181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ppeerttu can you regenerate the helm stuff to resolve the merge conflicts? |
@Sovietaced will do as soon as I'm back at the office, probably next Thursday! |
Signed-off-by: Perttu Kärnä <[email protected]>
ppeerttu
force-pushed
the
feature/configure-deployment-annotations
branch
from
9d71fb7 to
340b844
Compare
Code Review Agent Run #419294Actionable Suggestions - 0Additional Suggestions - 4
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
@ppeerttu I don't know why the doc build is failing, maybe try rebasing? |
|
@Sovietaced to me it looks like master is broken - I think the latest merged PR somehow managed to break the docs build. I'll see if I can find time to debug the build locally and come up with a fix. |
I made a PR lately and it had no issues building: #6419 Which is why I thought it's maybe not up to date and rebasing on main would help. |
|
Worked with the maintainers to remove the build step. Should be able to merge now. |
|
Congrats on merging your first pull request! 🎉 |
3 participants
Tracking issue
Why are the changes needed?
There is no feasible way to manage Flyte database secret rotation from external secret source when installing Flyte through Helm charts in AWS EKS (I doubt it's possible in other clouds either). This is a common approach taken with AWS RDS, where AWS manages the database secret rotation automatically through secrets manager. While external secrets operator is able to update Kubernetes native secrets based on changes in an external source (e.g. AWS Secrets Manager), it doesn't restart pods mounting those secrets, leaving the rotation incomplete in this case.
What changes were proposed in this pull request?
Add ability to annotate Kubernetes deployments created by the flyte-core Helm chart. This makes it possible to use external operators, such as Reloader, to rotate the pods using the secrets.
How was this patch tested?
Labels
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR adds configurable deployment annotations to Helm charts, enabling integration with external secret management tools like Reloader. It implements conditional annotation blocks across deployment templates based on configuration values, updates values.yaml with annotation guidance, and fixes secret rotation in Docker manifests for improved security.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2