Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2025

Bumps golang.org/x/crypto from 0.31.0 to 0.35.0.

Commits
  • 7292932 ssh: limit the size of the internal packet queue while waiting for KEX
  • f66f74b acme/autocert: check host policy before probing the cache
  • b0784b7 x509roots/fallback: drop obsolete build constraint
  • 911360c all: bump golang.org/x/crypto dependencies of asm generators
  • 89ff08d all: upgrade go directive to at least 1.23.0 [generated]
  • e47973b all: update certs for go1.24
  • 9290511 go.mod: update golang.org/x dependencies
  • fa5273e x509roots/fallback: update bundle
  • a8ea4be ssh: add ServerConfig.PreAuthConnCallback, ServerPreAuthConn (banner) interface
  • 71d3a4c acme: support challenges that require the ACME client to send a non-empty JSO...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Summary by Bito

This PR updates dependency versions in flyteidl module files, introducing a new toolchain directive and upgrading golang.org/x/crypto to version 0.35.0. It also updates related dependencies including golang.org/x/sync, golang.org/x/sys, golang.org/x/term, and golang.org/x/text to maintain compatibility with newer standards.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 14, 2025
@flyte-bot
Copy link
Collaborator

flyte-bot commented Apr 14, 2025

Code Review Agent Run #a31ac4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: d8e695b..d8e695b
    • flyteidl/go.mod
    • flyteidl/go.sum
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • SNYK (Security Vulnerability) - ✔︎ Successful
    • GOVULNCHECK (Security Vulnerability) - ✖︎ Failed
    • OWASP (Security Vulnerability) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Dependency Updates

go.mod - Added a new toolchain directive and updated dependency versions, including bumping golang.org/x/crypto from 0.31.0 to 0.35.0 and aligning other module dependencies.

go.sum - Refreshed checksum entries to reflect updated dependency versions for golang.org/x/crypto and related packages.

@Sovietaced
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/flyteidl/golang.org/x/crypto-0.35.0 branch from d8e695b to eac53ad Compare August 22, 2025 23:14
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.58%. Comparing base (d2058e4) to head (0740e40).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6414   +/-   ##
=======================================
  Coverage   58.57%   58.58%           
=======================================
  Files         929      929           
  Lines       70851    70851           
=======================================
+ Hits        41504    41509    +5     
+ Misses      26200    26195    -5     
  Partials     3147     3147           
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.12% <ø> (+0.02%) ⬆️
unittests-flytecopilot 39.56% <ø> (ø)
unittests-flytectl 64.64% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.10% <ø> (ø)
unittests-flytepropeller 55.06% <ø> (ø)
unittests-flytestdlib 63.09% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Sovietaced Sovietaced force-pushed the dependabot/go_modules/flyteidl/golang.org/x/crypto-0.35.0 branch from 56cb805 to e015266 Compare August 22, 2025 23:46
@Sovietaced
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/flyteidl/golang.org/x/crypto-0.35.0 branch from e015266 to ddd87f9 Compare August 22, 2025 23:50
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact [email protected] and provide the following details:

Agent Run ID: b8b9d5a8-468e-4597-9c80-c97742fa550f

@Sovietaced
Copy link
Member

https://github.com/dependabot recreate

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.31.0 to 0.35.0.
- [Commits](golang/crypto@v0.31.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.35.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/flyteidl/golang.org/x/crypto-0.35.0 branch from 7aaba2e to d7a6fe3 Compare August 23, 2025 00:27
Signed-off-by: Jason Parraga <[email protected]>
@Sovietaced Sovietaced merged commit 1a6bbeb into master Aug 23, 2025
52 checks passed
@Sovietaced Sovietaced deleted the dependabot/go_modules/flyteidl/golang.org/x/crypto-0.35.0 branch August 23, 2025 00:49
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact [email protected] and provide the following details:

Agent Run ID: b396b436-be32-457d-846e-fc285b2c38ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants