Skip to content

Conversation

ppiegaze
Copy link
Member

@ppiegaze ppiegaze commented Jun 20, 2025

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request corrects typographical errors in documentation and comments across multiple files, particularly focusing on DataLoading configuration and ChatGPT agent setup. These enhancements improve clarity and professionalism, ensuring accurate information for users.

@ppiegaze ppiegaze requested review from pingsutw and removed request for davidmirror-ops June 20, 2025 12:20
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (9c536fb) to head (72c1df4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6504   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         940      940           
  Lines       71532    71532           
=======================================
+ Hits        41864    41865    +1     
+ Misses      26489    26488    -1     
  Partials     3179     3179           
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.25% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.72% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.08% <ø> (ø)
unittests-flytepropeller 54.83% <ø> (ø)
unittests-flytestdlib 64.04% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced
Copy link
Member

@ppiegaze You'll need to sign off your commits and run make generate in the flyteidl directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants