Skip to content

Conversation

0yukali0
Copy link
Contributor

@0yukali0 0yukali0 commented Oct 10, 2025

Tracking issue

Related to #6657

Why are the changes needed?

check when the old version of flytectl may not be listed in the response from api.github.com.

What changes were proposed in this pull request?

  1. Check https://api.github.com/repos/${OWNER}/${REPO}/releases/tags/flytectl/${TAG}
  2. download if the url is work

How was this patch tested?

bash ./install.sh v0.8.19 # download v0.8.19
./bin/flytectl version
bash ./install.sh # download latest one
./bin/flytectl version

Labels

  • fixed

This is important to improve the readability of release notes.

Setup process

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request enhances the installation script for flytectl by adding checks for downloading older versions not listed in the GitHub API response. It introduces a new URL check to ensure specified versions can be retrieved, improving the robustness and user experience of version management.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.56%. Comparing base (996504d) to head (23570d9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6668      +/-   ##
==========================================
+ Coverage   57.88%   58.56%   +0.68%     
==========================================
  Files         770      929     +159     
  Lines       63679    70875    +7196     
==========================================
+ Hits        36858    41511    +4653     
- Misses      23972    26211    +2239     
- Partials     2849     3153     +304     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.13% <ø> (ø)
unittests-flytecopilot 40.87% <ø> (ø)
unittests-flytectl 64.64% <ø> (?)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.00% <ø> (ø)
unittests-flytepropeller 55.06% <ø> (ø)
unittests-flytestdlib 63.05% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants