-
Notifications
You must be signed in to change notification settings - Fork 759
Add description field in task and trigger protos #6722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Changes from 3 commits
1103899
7828dc1
a593d7a
1ad5a0a
6e4528d
a52087b
741286a
180b4fa
84c6dca
68fed82
d4e84c6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,6 +110,9 @@ message TaskMetadata { | |
|
|
||
| // Brief overview of attached triggers if any. | ||
| TaskTriggersSummary triggers_summary = 5; | ||
|
|
||
| // The short description for this task | ||
| string short_description = 6; | ||
| } | ||
|
|
||
| // Lightweight representation of a task. | ||
|
|
@@ -121,6 +124,22 @@ message Task { | |
| TaskMetadata metadata = 2 [(buf.validate.field).required = true]; | ||
| } | ||
|
|
||
| // Link to source code used to define this entity | ||
| message SourceCode { | ||
| string link = 1; | ||
|
|
||
| // Todo(alex): We should add remote, file path, and line number in the future for the backend to construct uri of Github or Gitlab | ||
| } | ||
|
|
||
| message DescriptionEntity { | ||
|
||
| // One-liner overview of the entity. | ||
| string short_description = 1 [(buf.validate.field).string.max_len = 255]; | ||
| // Full user description with formatting preserved. | ||
| string long_description = 2 [(buf.validate.field).string.max_len = 2048]; | ||
| // Optional link to source code used to define this entity. | ||
| SourceCode source_code = 3; | ||
| } | ||
|
|
||
| // Specification for a task. | ||
| message TaskSpec { | ||
| // The template for this task. | ||
|
|
@@ -137,6 +156,9 @@ message TaskSpec { | |
|
|
||
| // Optional environment for this task. Note, some tasks may not be run in the context of an environment. | ||
| Environment environment = 4; | ||
|
|
||
| // The description entity for the task | ||
| DescriptionEntity description = 5; | ||
| } | ||
|
|
||
| // Specification for a trace action. | ||
|
|
@@ -181,4 +203,7 @@ message TaskTriggerSpec { | |
|
|
||
| // The run spec for triggered task. | ||
| flyteidl2.task.RunSpec run_spec = 3; | ||
|
|
||
| // Optional description | ||
| string description = 4; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also consider sending a remote, a file path, and a line number, and letting the backend construct the actual link. but this is okay for now.