Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flyteidl2/task/environment.proto
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@ message Environment {
(buf.validate.field).string.min_len = 1,
(buf.validate.field).string.max_len = 63
];

// Description of environment
string description = 2 [(buf.validate.field).string.max_len = 255];
}
25 changes: 25 additions & 0 deletions flyteidl2/task/task_definition.proto
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ message TaskMetadata {

// Brief overview of attached triggers if any.
TaskTriggersSummary triggers_summary = 5;

// The short description for this task
string short_description = 6;
}

// Lightweight representation of a task.
Expand All @@ -121,6 +124,22 @@ message Task {
TaskMetadata metadata = 2 [(buf.validate.field).required = true];
}

// Link to source code used to define this entity
message SourceCode {
string link = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also consider sending a remote, a file path, and a line number, and letting the backend construct the actual link. but this is okay for now.


// Todo(alex): We should add remote, file path, and line number in the future for the backend to construct uri of Github or Gitlab
}

message DescriptionEntity {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this name but I can't think of anything better. cc @pingsutw any ideas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wild-endeavor Is the proto name "DocumentationEntity" sounds good to you?

// One-liner overview of the entity.
string short_description = 1 [(buf.validate.field).string.max_len = 255];
// Full user description with formatting preserved.
string long_description = 2 [(buf.validate.field).string.max_len = 2048];
// Optional link to source code used to define this entity.
SourceCode source_code = 3;
}

// Specification for a task.
message TaskSpec {
// The template for this task.
Expand All @@ -137,6 +156,9 @@ message TaskSpec {

// Optional environment for this task. Note, some tasks may not be run in the context of an environment.
Environment environment = 4;

// The description entity for the task
DescriptionEntity description = 5;
}

// Specification for a trace action.
Expand Down Expand Up @@ -181,4 +203,7 @@ message TaskTriggerSpec {

// The run spec for triggered task.
flyteidl2.task.RunSpec run_spec = 3;

// Optional description
string description = 4;
}
6 changes: 6 additions & 0 deletions flyteidl2/trigger/trigger_definition.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ message TriggerSpec {
(buf.validate.field).string.min_len = 1,
(buf.validate.field).string.max_len = 63
];

// Optional description
string description = 6;
}

message TriggerStatus {
Expand Down Expand Up @@ -84,6 +87,9 @@ message TriggerDetails {

// Optional automation spec.
flyteidl2.task.TriggerAutomationSpec automation_spec = 5;

// Trigger description
optional string description = 6 [(buf.validate.field).string.max_len = 255];
}

// Light-weight information about trigger for a list view
Expand Down
40 changes: 26 additions & 14 deletions gen/go/flyteidl2/task/environment.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions gen/go/flyteidl2/task/environment.pb.validate.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading