Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

katrogan
Copy link
Contributor

Read then delete

  • Make sure to use a concise title for the pull-request.
  • Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
    will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov-commenter
Copy link

Codecov Report

Merging #125 into master will decrease coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   62.26%   61.82%   -0.45%     
==========================================
  Files         105      105              
  Lines        7845     7901      +56     
==========================================
  Hits         4885     4885              
- Misses       2385     2441      +56     
  Partials      575      575              
Flag Coverage Δ
#unittests 61.82% <0.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/config/postgres.go 15.62% <0.00%> (-26.05%) ⬇️
pkg/runtime/application_config_provider.go 4.25% <0.00%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab4226...5a97c3d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants