Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: pmahindrakar-oss [email protected]

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: pmahindrakar-oss <[email protected]>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #515 (d72dcd2) into master (1ccd59c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   60.04%   60.08%   +0.03%     
==========================================
  Files         168      168              
  Lines       15010    15010              
==========================================
+ Hits         9013     9019       +6     
+ Misses       5203     5197       -6     
  Partials      794      794              
Flag Coverage Δ
unittests 60.08% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...implementations/workflow_execution_event_writer.go 68.42% <0.00%> (+31.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant