Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Empty structs for task resource defaults #530

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Feb 27, 2023

TL;DR

Currently if you don't specify anything, these defaults will spin up pods with

      limits:
        cpu: "2"
        memory: 200Mi
      requests:
        cpu: "2"
        memory: 200Mi

Removing this will make it

    resources:
      limits:
        cpu: "0"
        memory: "0"
      requests:
        cpu: "0"
        memory: "0"

which means that there is no limit

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@wild-endeavor wild-endeavor marked this pull request as draft March 1, 2023 22:40
@wild-endeavor
Copy link
Contributor Author

going to revise this. after discussing with hamersaw it feels unsafe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants